Bug 94662

Summary: IndexedDB: revert int version when version change transaction aborts
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dglazkov, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-04 none

David Grogan
Reported 2012-08-21 18:20:35 PDT
IndexedDB: revert int version when version change transaction aborts
Attachments
Patch (10.50 KB, patch)
2012-08-21 18:26 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (10.68 KB, patch)
2012-08-22 14:54 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-04 (1.33 MB, application/zip)
2012-08-22 15:46 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-08-21 18:26:43 PDT
Created attachment 159836 [details] Patch
David Grogan
Comment 2 2012-08-21 18:27:27 PDT
Josh, could you look at this?
Joshua Bell
Comment 3 2012-08-22 11:36:31 PDT
Comment on attachment 159836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159836&action=review lgtm > LayoutTests/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Replace this with brief overview. > LayoutTests/storage/indexeddb/resources/intversion-revert-on-abort.js:60 > + request.onerror = errorAfterAbortCallback; unexpectedErrorCallback?
David Grogan
Comment 4 2012-08-22 14:52:10 PDT
Comment on attachment 159836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159836&action=review >> LayoutTests/ChangeLog:8 >> + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). > > Replace this with brief overview. Done. >> LayoutTests/storage/indexeddb/resources/intversion-revert-on-abort.js:60 >> + request.onerror = errorAfterAbortCallback; > > unexpectedErrorCallback? Oops, fixed.
David Grogan
Comment 5 2012-08-22 14:54:23 PDT
Created attachment 160015 [details] Patch
David Grogan
Comment 6 2012-08-22 14:54:48 PDT
Tony, could you review this?
WebKit Review Bot
Comment 7 2012-08-22 15:46:26 PDT
Comment on attachment 160015 [details] Patch Attachment 160015 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13569402 New failing tests: http/tests/cache/post-with-cached-subresources.php
WebKit Review Bot
Comment 8 2012-08-22 15:46:29 PDT
Created attachment 160024 [details] Archive of layout-test-results from gce-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
WebKit Review Bot
Comment 9 2012-08-22 16:23:23 PDT
Comment on attachment 160015 [details] Patch Clearing flags on attachment: 160015 Committed r126366: <http://trac.webkit.org/changeset/126366>
WebKit Review Bot
Comment 10 2012-08-22 16:23:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.