Bug 94640

Summary:

(r126168): http/tests/inspector/console-resource-errors.html regression on mac

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pfeldman, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Undo skipping test.	none

Description Mark Lam 2012-08-21 15:55:27 PDT

The change for "Web Inspector: do not use window's eval in InjectedScript" https://bugs.webkit.org/show_bug.cgi?id=94610 (r126168) caused a regression on test http/tests/inspector/console-resource-errors.html on mac.  See:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r126184%20(2456)/http/tests/inspector/console-resource-errors-pretty-diff.html

Comment 1 Pavel Feldman 2012-08-21 19:42:50 PDT

Test just needs rebaseline.

Comment 2 Mark Lam 2012-08-21 22:43:16 PDT

The test has been skipped for platform/mac in https://bugs.webkit.org/show_bug.cgi?id=94646 (r126244).  Please revert this change when this bug is fixed.  Thanks.

Comment 3 Mark Lam 2012-08-22 10:01:56 PDT

The test was rebaseline'd in r126281 and no longer fails.

Comment 4 Mark Lam 2012-08-22 10:07:31 PDT

Created attachment 159957 [details]
Undo skipping test.

Comment 5 WebKit Review Bot 2012-08-22 10:32:54 PDT

Comment on attachment 159957 [details]
Undo skipping test.

Clearing flags on attachment: 159957

Committed r126316: <http://trac.webkit.org/changeset/126316>

Comment 6 WebKit Review Bot 2012-08-22 10:32:57 PDT

All reviewed patches have been landed.  Closing bug.