Bug 94640

Summary: (r126168): http/tests/inspector/console-resource-errors.html regression on mac
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Undo skipping test. none

Mark Lam
Reported 2012-08-21 15:55:27 PDT
The change for "Web Inspector: do not use window's eval in InjectedScript" https://bugs.webkit.org/show_bug.cgi?id=94610 (r126168) caused a regression on test http/tests/inspector/console-resource-errors.html on mac. See: http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r126184%20(2456)/http/tests/inspector/console-resource-errors-pretty-diff.html
Attachments
Undo skipping test. (1.21 KB, patch)
2012-08-22 10:07 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-08-21 19:42:50 PDT
Test just needs rebaseline.
Mark Lam
Comment 2 2012-08-21 22:43:16 PDT
The test has been skipped for platform/mac in https://bugs.webkit.org/show_bug.cgi?id=94646 (r126244). Please revert this change when this bug is fixed. Thanks.
Mark Lam
Comment 3 2012-08-22 10:01:56 PDT
The test was rebaseline'd in r126281 and no longer fails.
Mark Lam
Comment 4 2012-08-22 10:07:31 PDT
Created attachment 159957 [details] Undo skipping test.
WebKit Review Bot
Comment 5 2012-08-22 10:32:54 PDT
Comment on attachment 159957 [details] Undo skipping test. Clearing flags on attachment: 159957 Committed r126316: <http://trac.webkit.org/changeset/126316>
WebKit Review Bot
Comment 6 2012-08-22 10:32:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.