WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94610
Web Inspector: do not use window's eval in InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=94610
Summary
Web Inspector: do not use window's eval in InjectedScript
Pavel Feldman
Reported
2012-08-21 09:54:35 PDT
Otherwise, inspector does not work when eval is overriden.
Attachments
Patch
(8.99 KB, patch)
2012-08-21 09:56 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(9.02 KB, patch)
2012-08-21 09:59 PDT
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-08-21 09:56:49 PDT
Created
attachment 159706
[details]
Patch
Pavel Feldman
Comment 2
2012-08-21 09:59:40 PDT
Created
attachment 159708
[details]
Patch
Pavel Feldman
Comment 3
2012-08-21 10:02:58 PDT
Committed
r126168
: <
http://trac.webkit.org/changeset/126168
>
Mark Lam
Comment 4
2012-08-21 15:30:07 PDT
This change broke http/tests/inspector/console-resource-errors.html on mac. See:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r126184%20(2456)/http/tests/inspector/console-resource-errors-pretty-diff.html
Zoltan Arvai
Comment 5
2012-08-22 00:32:05 PDT
(In reply to
comment #4
)
> This change broke http/tests/inspector/console-resource-errors.html on mac. See: >
http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r126184%20(2456)/http/tests/inspector/console-resource-errors-pretty-diff.html
Also it fails on EFL and Qt. Rebaseline?
Pavel Feldman
Comment 6
2012-08-22 01:11:49 PDT
Single rebaseline would fix them all.
Zoltan Arvai
Comment 7
2012-08-22 02:13:51 PDT
(In reply to
comment #6
)
> Single rebaseline would fix them all.
Rebaseline done in
r126281
:)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug