Bug 94610 - Web Inspector: do not use window's eval in InjectedScript
Summary: Web Inspector: do not use window's eval in InjectedScript
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 09:54 PDT by Pavel Feldman
Modified: 2012-08-22 02:13 PDT (History)
17 users (show)

See Also:

Attachments
Patch (8.99 KB, patch)
2012-08-21 09:56 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (9.02 KB, patch)
2012-08-21 09:59 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-21 09:54:35 PDT 
Otherwise, inspector does not work when eval is overriden.
Comment 1 Pavel Feldman 2012-08-21 09:56:49 PDT 
Created attachment 159706 [details]
Patch
Comment 2 Pavel Feldman 2012-08-21 09:59:40 PDT 
Created attachment 159708 [details]
Patch
Comment 3 Pavel Feldman 2012-08-21 10:02:58 PDT 
Committed r126168: <http://trac.webkit.org/changeset/126168>
Comment 4 Mark Lam 2012-08-21 15:30:07 PDT 
This change broke http/tests/inspector/console-resource-errors.html on mac.  See:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r126184%20(2456)/http/tests/inspector/console-resource-errors-pretty-diff.html
Comment 5 Zoltan Arvai 2012-08-22 00:32:05 PDT 
(In reply to comment #4)
> This change broke http/tests/inspector/console-resource-errors.html on mac.  See:
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r126184%20(2456)/http/tests/inspector/console-resource-errors-pretty-diff.html


Also it fails on EFL and Qt. Rebaseline?
Comment 6 Pavel Feldman 2012-08-22 01:11:49 PDT 
Single rebaseline would fix them all.
Comment 7 Zoltan Arvai 2012-08-22 02:13:51 PDT 
(In reply to comment #6)
> Single rebaseline would fix them all.

Rebaseline done in r126281 :)