Summary: | [BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Meyer <ben> | ||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mifenton, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Meyer
2012-08-21 11:46:15 PDT
Created attachment 159741 [details]
patch
Comment on attachment 159741 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=159741&action=review > Source/WebKit/blackberry/Api/WebPage.h:387 > + void enableQnxJavaScriptObject(bool); Naming: 1. Qnx should be QNX 2. WebKit usually use setFooEnabled(boo) Comment on attachment 159741 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=159741&action=review >> Source/WebKit/blackberry/Api/WebPage.h:387 >> + void enableQnxJavaScriptObject(bool); > > Naming: > 1. Qnx should be QNX > 2. WebKit usually use setFooEnabled(boo) hm.. probably Qnx is ok because the js object is "qnx" On the API note, the BlackBerry port api is inconsistent, has setFooEnabled(), enableFoo() and setEnableFoo() which is why I just picked one. Comment on attachment 159741 [details] patch Clearing flags on attachment: 159741 Committed r126232: <http://trac.webkit.org/changeset/126232> All reviewed patches have been landed. Closing bug. |