range-hit-test-with-padding.html fails unless subpixel layout is on

• Component: Forms
• Status: RESOLVED FIXED

[Keishi Hattori]

Slider thumb width is an odd number and we divide that by two, so we get different results depending on whether subpixel layout is turned on or not.

[Keishi Hattori]

Created attachment 159666 [details]
Patch

[Kent Tamura]

Comment on attachment 159666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review

> LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9
> -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;">
> +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;">

I recommend adding some step value.

[Kent Tamura]

(In reply to comment #2)
> (From update of attachment 159666 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review
> 
> > LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9
> > -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;">
> > +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;">
> 
> I recommend adding some step value.

I mean increasing the step value. e.g. step=20

[Keishi Hattori]

Created attachment 159672 [details]
Patch

[Keishi Hattori]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 159666 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review
> > 
> > > LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9
> > > -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;">
> > > +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;">
> > 
> > I recommend adding some step value.
> 
> I mean increasing the step value. e.g. step=20

That is much better! Adjusted the max to 25 so this will work as long as the thumb width is less than 50px.

[Thiago Marcos P. Santos]

This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working.

Try changing to something like "padding: 0 400px;" and test on chromium.

[Thiago Marcos P. Santos]

(In reply to comment #6)
> This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working.
> 
> Try changing to something like "padding: 0 400px;" and test on chromium.

Sorry for bumping. By test here I'm talking about see how it looks like on the browser.

[Thiago Marcos P. Santos]

(In reply to comment #7)
> (In reply to comment #6)
> > This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working.
> > 
> > Try changing to something like "padding: 0 400px;" and test on chromium.
> 
> Sorry for bumping. By test here I'm talking about see how it looks like on the browser.

Argh, EFL padding is broken. Sorry for the noise.

[WebKit Review Bot]

Comment on attachment 159672 [details]
Patch

Attachment 159672 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13551362

New failing tests:
fast/forms/range/range-hit-test-with-padding.html

[WebKit Review Bot]

Created attachment 159719 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Keishi Hattori]

Created attachment 159825 [details]
Patch

[WebKit Review Bot]

Comment on attachment 159825 [details]
Patch

Clearing flags on attachment: 159825

Committed r126252: <http://trac.webkit.org/changeset/126252>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.