Bug 94580

Summary:

Web Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, alph, apavlov, bweinstein, cmarcelo, eric.carlson, eric, feature-media-reviews, japhet, joepeck, keishi, loislo, macpherson, menard, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

87262

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
actually landed	none

Ilya Tikhonovsky

Reported 2012-08-21 03:09:37 PDT

EOM

Attachments
Patch (41.94 KB, patch) 2012-08-21 03:13 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Patch (41.93 KB, patch) 2012-08-21 05:35 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Patch (43.12 KB, patch) 2012-08-21 06:11 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
actually landed (45.54 KB, patch) 2012-08-21 06:44 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2012-08-21 03:13:22 PDT

Created attachment 159639 [details] Patch

Yury Semikhatsky

Comment 2 2012-08-21 04:45:57 PDT

Comment on attachment 159639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159639&action=review > Source/WebCore/dom/MemoryInstrumentation.h:106 > + void addInstrumentedObject(const String&, ObjectType); We should merge these methods into corresponding addInstrumentedObjectImpl. > Source/WebCore/dom/MemoryInstrumentation.h:219 > + void addInstrumentedMember(const String& string) { m_memoryInstrumentation->addInstrumentedObject(string, m_objectType); } Having overloaded version of addInstrumentedObjectImpl should be enough for generic addInstrumentedMember method to work here.

Ilya Tikhonovsky

Comment 3 2012-08-21 05:35:20 PDT

Created attachment 159665 [details] Patch

Build Bot

Comment 4 2012-08-21 06:00:08 PDT

Comment on attachment 159665 [details] Patch Attachment 159665 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13554149

Yury Semikhatsky

Comment 5 2012-08-21 06:02:37 PDT

Comment on attachment 159665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159665&action=review > Source/WebCore/dom/MemoryInstrumentation.cpp:64 > + addObject(url->innerURL(), objectType); addObject -> addInstrumentedObject, can you check why didn't the compilation failed on this call?

Ilya Tikhonovsky

Comment 6 2012-08-21 06:11:44 PDT

Created attachment 159674 [details] Patch

Ilya Tikhonovsky

Comment 7 2012-08-21 06:12:43 PDT

(In reply to comment #5) > (From update of attachment 159665 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159665&action=review > > > Source/WebCore/dom/MemoryInstrumentation.cpp:64 > > + addObject(url->innerURL(), objectType); > > addObject -> addInstrumentedObject, can you check why didn't the compilation failed on this call? fixed. link time guards were moved to MemoryInstrumentation

Ilya Tikhonovsky

Comment 8 2012-08-21 06:44:36 PDT

Created attachment 159680 [details] actually landed actually landed patch

Note You need to log in before you can comment on or make changes to this bug.