Bug 94567

Summary: _compare_image() swaps actual and expected images by mistake
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ojan: review+

Description Simon Fraser (smfr) 2012-08-20 20:25:57 PDT
I'm pretty sure that _compare_image() is swapping the images by mistake:

            diff_result = self._port.diff_image(driver_output.image, expected_driver_output.image)

    def diff_image(self, expected_contents, actual_contents, tolerance):

Note flipped order of params.
Comment 1 Simon Fraser (smfr) 2012-08-20 20:30:30 PDT
Created attachment 159604 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-08-20 21:49:38 PDT
Comment on attachment 159604 [details]
Patch

Dirk wants to fix this another way.
Comment 4 Dirk Pranke 2012-08-21 13:20:27 PDT
Created attachment 159751 [details]
Patch
Comment 5 Dirk Pranke 2012-08-21 14:35:49 PDT
Committed r126188: <http://trac.webkit.org/changeset/126188>