| Summary: | Cleanup TestExpectationParser.parse | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, ojan, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 89161 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2012-08-20 16:32:49 PDT
Created attachment 159560 [details]
Cleanup
Comment on attachment 159560 [details]
Cleanup
So, the change looks more or less correct, but it's not obvious to me that it's better. Can you update the changelog to say why you think things are better (or just update the bug)? Maybe it'll make subsequent refactoring easier or something?
(In reply to comment #2) > (From update of attachment 159560 [details]) > So, the change looks more or less correct, but it's not obvious to me that it's better. Can you update the changelog to say why you think things are better (or just update the bug)? Maybe it'll make subsequent refactoring easier or something? I'm trying to reduce the number of functions to make the subsequent refactoring easier. Also, the check for having both timeout and slow was done in _parse_line instead of _parse_modifiers where other modifier errors were generated. ok. Comment on attachment 159560 [details] Cleanup Clearing flags on attachment: 159560 Committed r126135: <http://trac.webkit.org/changeset/126135> All reviewed patches have been landed. Closing bug. |