Bug 94511

Summary:

CodeGeneratorInspector.py: Generate guards for type validators

Product:

WebKit

Reporter:

Thiago Marcos P. Santos <tmpsantos>

Component:

WebKit EFL

Assignee:

Thiago Marcos P. Santos <tmpsantos>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aandrey, cdumez, lucas.de.marchi, pfeldman, rakuco, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

88973

Attachments:

Description	Flags
Patch	none
Generated InspectorTypeBuilder.cpp before the patch.	none
Generated InspectorTypeBuilder.cpp after the patch.	none
Patch	none
Generated InspectorTypeBuilder.cpp after the patch.	none
Patch	none

Description Thiago Marcos P. Santos 2012-08-20 12:07:42 PDT

EFL Debug bots are broken after r126028. Release build looks like was unaffected, which makes me think we have something missing for NDEBUG flags.

Comment 1 Thiago Marcos P. Santos 2012-08-20 12:23:57 PDT

The problem is not on bug 88973, but on the code generator. It was just exposed by the patch.

Comment 2 Thiago Marcos P. Santos 2012-08-20 14:49:26 PDT

Created attachment 159526 [details]
Patch

Comment 3 Thiago Marcos P. Santos 2012-08-20 15:25:00 PDT

Created attachment 159534 [details]
Generated InspectorTypeBuilder.cpp before the patch.

Comment 4 Thiago Marcos P. Santos 2012-08-20 15:25:31 PDT

Created attachment 159535 [details]
Generated InspectorTypeBuilder.cpp after the patch.

Comment 5 Andrey Adaikin 2012-08-21 00:23:33 PDT

Yeah, thanks for fixing this!

Comment 6 Thiago Marcos P. Santos 2012-08-21 00:27:17 PDT

(In reply to comment #5)
> Yeah, thanks for fixing this!

Can you help me to find a reviewer for this patch? I have 2 debug bots broken since yesterday because of this regression.

Comment 7 Yury Semikhatsky 2012-08-21 00:29:10 PDT

Comment on attachment 159526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159526&action=review

A couple of nits otherwise looks good.

> Source/WebCore/inspector/CodeGeneratorInspector.py:931
> +                                    if domain_guard:

The closing guard should go right after "}" and be followed by "\n\n\n" to match the coding style when there is no guard.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1338
> +                                    if domain_guard:

Same here.

Comment 8 Thiago Marcos P. Santos 2012-08-21 00:35:01 PDT

Comment on attachment 159526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159526&action=review

>> Source/WebCore/inspector/CodeGeneratorInspector.py:931
>> +                                    if domain_guard:
> 
> The closing guard should go right after "}" and be followed by "\n\n\n" to match the coding style when there is no guard.

You probably meant after "}\n" and followed by "\n\n", right?

Comment 9 Thiago Marcos P. Santos 2012-08-21 00:36:15 PDT

Created attachment 159632 [details]
Patch

Comment 10 Thiago Marcos P. Santos 2012-08-21 00:38:12 PDT

Created attachment 159633 [details]
Generated InspectorTypeBuilder.cpp after the patch.

Comment 11 Thiago Marcos P. Santos 2012-08-21 00:41:58 PDT

Created attachment 159634 [details]
Patch

Added copyright notice.

Comment 12 WebKit Review Bot 2012-08-21 16:09:32 PDT

Comment on attachment 159634 [details]
Patch

Clearing flags on attachment: 159634

Committed r126206: <http://trac.webkit.org/changeset/126206>

Comment 13 WebKit Review Bot 2012-08-21 16:09:36 PDT

All reviewed patches have been landed.  Closing bug.