Bug 94482

Summary: [BlackBerry] Persist cookies not from atexit() but the new onThreadFinished()
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, mifenton, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jakob Petsovits
Reported 2012-08-20 07:45:14 PDT
Our port is making some changes to shut down all threads correctly when the process exits. We're therefore introducing a new onThreadFinished() virtual for MessageClients, which is nicer than setting an atexit() handler from within WebKit. Here's the patch to make use of that functionality in WebKit.
Attachments
Patch (6.34 KB, patch)
2012-08-20 07:53 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Patch (6.69 KB, patch)
2012-08-20 11:47 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2012-08-20 07:53:40 PDT
Created attachment 159428 [details] Patch
Yong Li
Comment 2 2012-08-20 08:32:50 PDT
Comment on attachment 159428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159428&action=review > Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + No new functionality, no new tests. need some description between these 2 lines :) > Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:89 > + CookieLog("CookieManager - flushing cookies to backingStore..."); should be cookieLog() according to webkit style?
Jakob Petsovits
Comment 3 2012-08-20 11:47:14 PDT
Created attachment 159481 [details] Patch
Jakob Petsovits
Comment 4 2012-08-20 11:48:51 PDT
I talked to Yong and he revoked his wish for renaming CookieLog(), as it affects a multitude of other lines in the same file and consequently would expand the scope of this patch significantly.
WebKit Review Bot
Comment 5 2012-08-20 12:23:56 PDT
Comment on attachment 159481 [details] Patch Clearing flags on attachment: 159481 Committed r126053: <http://trac.webkit.org/changeset/126053>
WebKit Review Bot
Comment 6 2012-08-20 12:23:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.