Bug 94459

Summary: [V8] Move clearForClose() and clearForNavigation() from V8Proxy to ScriptController
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-08-20 02:27:19 PDT
To kill V8Proxy, we can move clearForClose() and clearForNavigation() from V8Proxy to ScriptController.
Attachments
Patch (7.94 KB, patch)
2012-08-20 02:32 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-20 02:32:39 PDT
Created attachment 159379 [details] Patch
Adam Barth
Comment 2 2012-08-20 11:29:46 PDT
Comment on attachment 159379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159379&action=review > Source/WebCore/bindings/v8/ScriptController.cpp:156 > + m_proxy->isolatedWorlds().clear(); > + m_proxy->isolatedWorldSecurityOrigins().clear(); This is a bit odd, but these functions already have FIXME comments, so I take it that this is a temporary measure.
Kentaro Hara
Comment 3 2012-08-20 14:58:06 PDT
(In reply to comment #2) > > + m_proxy->isolatedWorlds().clear(); > > + m_proxy->isolatedWorldSecurityOrigins().clear(); > > This is a bit odd, but these functions already have FIXME comments, so I take it that this is a temporary measure. Yes, these will be removed in this week.
WebKit Review Bot
Comment 4 2012-08-20 16:18:33 PDT
Comment on attachment 159379 [details] Patch Clearing flags on attachment: 159379 Committed r126086: <http://trac.webkit.org/changeset/126086>
WebKit Review Bot
Comment 5 2012-08-20 16:18:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.