Bug 94455

Summary: [V8] Move collectGarbage() from ScriptController to V8GCController
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2012-08-20 01:47:17 PDT
We can move collectGarbage() from ScriptController to V8GCController. Also we can remove ScriptController::lowMemoryNotification() since it is not used at all.
Attachments
Patch (6.71 KB, patch)
2012-08-20 01:51 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (3.19 KB, patch)
2012-08-20 17:15 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-20 01:51:19 PDT
Created attachment 159368 [details] Patch
Adam Barth
Comment 2 2012-08-20 11:20:21 PDT
Comment on attachment 159368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159368&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:534 > +void V8GCController::collectGarbage() It's a bit strange that collectGarbageIfNecessary is so different from collectGarbage. > Source/WebCore/bindings/v8/V8GCController.cpp:538 > + v8::Persistent<v8::Context> v8Context = v8::Context::New(); v8Context -> context
Kentaro Hara
Comment 3 2012-08-20 17:02:47 PDT
Committed r126098: <http://trac.webkit.org/changeset/126098>
Kentaro Hara
Comment 4 2012-08-20 17:06:51 PDT
(In reply to comment #2) > > Source/WebCore/bindings/v8/V8GCController.cpp:534 > > +void V8GCController::collectGarbage() > > It's a bit strange that collectGarbageIfNecessary is so different from collectGarbage. collectGarbage() always collects garbage. collectGarbageIfNecessary() just sends an idle notification to V8, which is just a hint for V8 to trigger GC. Maybe can we rename collectGarbageIfNecessary() to hintForCollectGarbage()? > > Source/WebCore/bindings/v8/V8GCController.cpp:538 > > + v8::Persistent<v8::Context> v8Context = v8::Context::New(); > > v8Context -> context Done.
Adam Barth
Comment 5 2012-08-20 17:09:38 PDT
> hintForCollectGarbage Ok. I think that's the name you had before I asked you to change it. :)
Kentaro Hara
Comment 6 2012-08-20 17:15:22 PDT
Reopening to attach new patch.
Kentaro Hara
Comment 7 2012-08-20 17:15:26 PDT
Created attachment 159568 [details] Patch
WebKit Review Bot
Comment 8 2012-08-20 19:47:37 PDT
Comment on attachment 159568 [details] Patch Clearing flags on attachment: 159568 Committed r126123: <http://trac.webkit.org/changeset/126123>
WebKit Review Bot
Comment 9 2012-08-20 19:47:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.