Bug 94446

Summary: [V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch none

Description Kentaro Hara 2012-08-19 23:03:36 PDT 
To kill V8Proxy, we can move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController.
Comment 1 Kentaro Hara 2012-08-19 23:14:06 PDT 
Created attachment 159338 [details]
Patch
Comment 2 Adam Barth 2012-08-19 23:28:40 PDT 
Comment on attachment 159338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159338&action=review

This code is kind of nuts.

> Source/WebCore/bindings/v8/ScriptController.cpp:532
> +    char buffer[32];
> +    snprintf(buffer, sizeof(buffer), "page,%d", debugId);

Can you add buffer[31] = '\0' ?

> Source/WebCore/bindings/v8/V8IsolatedContext.cpp:85
>      // Setup context id for JS debugger.

I'd remove this comment.
Comment 3 Kentaro Hara 2012-08-20 00:53:53 PDT 
Committed r126005: <http://trac.webkit.org/changeset/126005>
Comment 4 Kentaro Hara 2012-08-20 00:54:29 PDT 
(In reply to comment #2)
> Can you add buffer[31] = '\0' ?
> 
> > Source/WebCore/bindings/v8/V8IsolatedContext.cpp:85
> >      // Setup context id for JS debugger.
> 
> I'd remove this comment.

Done. Thanks!