Bug 94443

Summary: [V8] Move V8Proxy::newInstance() to V8ObjectConstructor
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch
none
Patch
none
patch for landing
haraken: commit-queue-
patch for landing none

Description Kentaro Hara 2012-08-19 21:56:08 PDT 
To kill V8Proxy, we can move V8Proxy::newInstance() to V8ObjectConstructor.
Comment 1 Kentaro Hara 2012-08-19 22:15:31 PDT 
Created attachment 159331 [details]
Patch
Comment 2 Kentaro Hara 2012-08-19 22:23:51 PDT 
Created attachment 159332 [details]
Patch
Comment 3 Adam Barth 2012-08-19 23:02:26 PDT 
Comment on attachment 159332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159332&action=review

> Source/WebCore/bindings/v8/V8Binding.cpp:384
> +void assertIfV8IsDead()

assertIfV8IsDead -> crashIfV8IsDead

This happens in release too, so it shouldn't say "alert"

> Source/WebCore/bindings/v8/V8ObjectConstructor.cpp:71
> +v8::Local<v8::Object> V8ObjectConstructor::newInstanceInFrame(v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[], Frame* frame)

Can we pass in a Document rather than a Frame here?  Using a Frame for a context object isn't correct.
Comment 4 Kentaro Hara 2012-08-19 23:21:56 PDT 
Created attachment 159339 [details]
patch for landing
Comment 5 Kentaro Hara 2012-08-19 23:22:48 PDT 
(In reply to comment #3)
> assertIfV8IsDead -> crashIfV8IsDead
> 
> > +v8::Local<v8::Object> V8ObjectConstructor::newInstanceInFrame(v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[], Frame* frame)
> 
> Can we pass in a Document rather than a Frame here?  Using a Frame for a context object isn't correct.

Done. Thanks for review.
Comment 6 Kentaro Hara 2012-08-19 23:52:26 PDT 
Created attachment 159345 [details]
patch for landing
Comment 7 WebKit Review Bot 2012-08-20 00:47:43 PDT 
Comment on attachment 159345 [details]
patch for landing

Clearing flags on attachment: 159345

Committed r126004: <http://trac.webkit.org/changeset/126004>