Bug 94439

Summary:

[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Mac

Product:

WebKit

Reporter:

yosin

Component:

Tools / Tests

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, macpherson, menard, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

95055

Bug Blocks:

Attachments:

Description	Flags
Patch 1	none
Patch 2	none
Patch 3	none

yosin

Reported 2012-08-19 18:27:34 PDT

Chromium Mac port failed on time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html. It seems this failure is caused by CSS selector difference in Chromium Mac port.

Attachments
Patch 1 (163.47 KB, patch) 2012-08-19 21:25 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 2 (163.47 KB, patch) 2012-08-19 21:49 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 3 (163.47 KB, patch) 2012-08-19 21:52 PDT, yosin	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

yosin

Comment 1 2012-08-19 21:25:21 PDT

Created attachment 159325 [details] Patch 1

yosin

Comment 2 2012-08-19 21:26:08 PDT

Comment on attachment 159325 [details] Patch 1 Could you review this patch? Thanks in advance.

Kent Tamura

Comment 3 2012-08-19 21:35:04 PDT

Comment on attachment 159325 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=159325&action=review > LayoutTests/ChangeLog:13 > + (.host): Changed padding select. 'padding' is not a selector. It's a CSS property. > LayoutTests/ChangeLog:14 > + (.ampmField): Remove wrong selector. ditto.

yosin

Comment 4 2012-08-19 21:49:14 PDT

Created attachment 159327 [details] Patch 2

yosin

Comment 5 2012-08-19 21:52:03 PDT

Created attachment 159328 [details] Patch 3

yosin

Comment 6 2012-08-19 21:53:11 PDT

Comment on attachment 159328 [details] Patch 3 Clearing flags on attachment: 159328 Committed r125996: <http://trac.webkit.org/changeset/125996>

yosin

Comment 7 2012-08-19 21:53:18 PDT

All reviewed patches have been landed. Closing bug.

yosin

Comment 8 2012-08-20 00:40:14 PDT

Spin button elements are still different...

yosin

Comment 9 2012-08-28 19:28:57 PDT

I did rebaseline (http://trac.webkit.org/changeset/126843)

Note You need to log in before you can comment on or make changes to this bug.