Bug 94438

Summary: [V8] Move m_windowShell from V8Proxy to ScriptController
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dcarney, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-08-19 18:15:05 PDT
m_windowShell should be owned by ScriptController. After this change, I can move a bunch of V8Proxy methods that access windowShell() from V8Proxy to ScriptController.
Attachments
Patch (6.46 KB, patch)
2012-08-19 18:44 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-19 18:44:55 PDT
Created attachment 159316 [details] Patch
Adam Barth
Comment 2 2012-08-19 20:46:09 PDT
Comment on attachment 159316 [details] Patch I thought I tried this before and there was some complication, but perhaps that complication has been removed. This patch certainly look straightforward and correct. Note: We eventually want ScriptController to hold a map from DOMWrapperWorld to V8WindowShell, but that's a separate effort.
Adam Barth
Comment 3 2012-08-19 20:48:32 PDT
@dcarney: Related to your work with making a WindowShell per DOMWrapperWorld.
WebKit Review Bot
Comment 4 2012-08-19 21:32:30 PDT
Comment on attachment 159316 [details] Patch Clearing flags on attachment: 159316 Committed r125993: <http://trac.webkit.org/changeset/125993>
WebKit Review Bot
Comment 5 2012-08-19 21:32:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.