Bug 94422

Summary: Web Inspector: toolbar causes 8 reflows upon opening
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch none

Description Pavel Feldman 2012-08-18 22:31:32 PDT
Toolbar's overflow code causes inspector for do 8 reflows upon opening. Fixing it via introducing batch toolbar updates.
Comment 1 Pavel Feldman 2012-08-18 22:54:41 PDT
Created attachment 159281 [details]
Comment 2 Yury Semikhatsky 2012-08-19 23:27:46 PDT
Comment on attachment 159281 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=159281&action=review

> Source/WebCore/inspector/front-end/Toolbar.js:55
> +        if (!this._coalescingLevel)

No need to check it here.

> Source/WebCore/inspector/front-end/inspector.js:519
> +    this.toolbar.setCoalescingUpdate(true);

Consider changing addPanel() to addPanels() that would encapsulate this optimization for batch mode or pass the batchMode flag as an explicit parameter to addPanel.
Comment 3 WebKit Review Bot 2012-08-20 00:21:32 PDT
Comment on attachment 159281 [details]

Clearing flags on attachment: 159281

Committed r126001: <http://trac.webkit.org/changeset/126001>
Comment 4 WebKit Review Bot 2012-08-20 00:21:36 PDT
All reviewed patches have been landed.  Closing bug.