Bug 94422

Summary: Web Inspector: toolbar causes 8 reflows upon opening
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Pavel Feldman
Reported 2012-08-18 22:31:32 PDT
Toolbar's overflow code causes inspector for do 8 reflows upon opening. Fixing it via introducing batch toolbar updates.
Attachments
Patch (8.30 KB, patch)
2012-08-18 22:54 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-08-18 22:54:41 PDT
Created attachment 159281 [details] Patch
Yury Semikhatsky
Comment 2 2012-08-19 23:27:46 PDT
Comment on attachment 159281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159281&action=review > Source/WebCore/inspector/front-end/Toolbar.js:55 > + if (!this._coalescingLevel) No need to check it here. > Source/WebCore/inspector/front-end/inspector.js:519 > + this.toolbar.setCoalescingUpdate(true); Consider changing addPanel() to addPanels() that would encapsulate this optimization for batch mode or pass the batchMode flag as an explicit parameter to addPanel.
WebKit Review Bot
Comment 3 2012-08-20 00:21:32 PDT
Comment on attachment 159281 [details] Patch Clearing flags on attachment: 159281 Committed r126001: <http://trac.webkit.org/changeset/126001>
WebKit Review Bot
Comment 4 2012-08-20 00:21:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.