Bug 94420

Summary:

Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

CSS

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, haraken, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2012-08-18 17:49:46 PDT

Keeping literal constant as local static WTF::String is a bad idea.

Comment 1 Benjamin Poulain 2012-08-18 18:00:00 PDT

Created attachment 159278 [details]
Patch

Comment 2 Kentaro Hara 2012-08-18 21:55:18 PDT

Comment on attachment 159278 [details]
Patch

Looks reasonable.

Comment 3 Benjamin Poulain 2012-08-19 20:40:05 PDT

Comment on attachment 159278 [details]
Patch

Clearing flags on attachment: 159278

Committed r125990: <http://trac.webkit.org/changeset/125990>

Comment 4 Benjamin Poulain 2012-08-19 20:40:07 PDT

All reviewed patches have been landed.  Closing bug.