Bug 94420

Summary: Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: CSSAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, haraken, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2012-08-18 17:49:46 PDT
Keeping literal constant as local static WTF::String is a bad idea.
Attachments
Patch (3.99 KB, patch)
2012-08-18 18:00 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-08-18 18:00:00 PDT
Created attachment 159278 [details] Patch
Kentaro Hara
Comment 2 2012-08-18 21:55:18 PDT
Comment on attachment 159278 [details] Patch Looks reasonable.
Benjamin Poulain
Comment 3 2012-08-19 20:40:05 PDT
Comment on attachment 159278 [details] Patch Clearing flags on attachment: 159278 Committed r125990: <http://trac.webkit.org/changeset/125990>
Benjamin Poulain
Comment 4 2012-08-19 20:40:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.