WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94420
Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT
https://bugs.webkit.org/show_bug.cgi?id=94420
Summary
Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER...
Benjamin Poulain
Reported
2012-08-18 17:49:46 PDT
Keeping literal constant as local static WTF::String is a bad idea.
Attachments
Patch
(3.99 KB, patch)
2012-08-18 18:00 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2012-08-18 18:00:00 PDT
Created
attachment 159278
[details]
Patch
Kentaro Hara
Comment 2
2012-08-18 21:55:18 PDT
Comment on
attachment 159278
[details]
Patch Looks reasonable.
Benjamin Poulain
Comment 3
2012-08-19 20:40:05 PDT
Comment on
attachment 159278
[details]
Patch Clearing flags on attachment: 159278 Committed
r125990
: <
http://trac.webkit.org/changeset/125990
>
Benjamin Poulain
Comment 4
2012-08-19 20:40:07 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug