Bug 94420 - Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT
Summary: Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-18 17:49 PDT by Benjamin Poulain
Modified: 2012-08-19 20:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.99 KB, patch)
2012-08-18 18:00 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-08-18 17:49:46 PDT 
Keeping literal constant as local static WTF::String is a bad idea.
Comment 1 Benjamin Poulain 2012-08-18 18:00:00 PDT 
Created attachment 159278 [details]
Patch
Comment 2 Kentaro Hara 2012-08-18 21:55:18 PDT 
Comment on attachment 159278 [details]
Patch

Looks reasonable.
Comment 3 Benjamin Poulain 2012-08-19 20:40:05 PDT 
Comment on attachment 159278 [details]
Patch

Clearing flags on attachment: 159278

Committed r125990: <http://trac.webkit.org/changeset/125990>
Comment 4 Benjamin Poulain 2012-08-19 20:40:07 PDT 
All reviewed patches have been landed.  Closing bug.