Bug 94390

Summary: REGRESSION (r125912): Crashes in worker tests
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore JavaScriptAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, beidson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 94220    
Bug Blocks:    
Attachments:
Description Flags
proposed fix beidson: review+

Alexey Proskuryakov
Reported 2012-08-17 16:06:17 PDT
Not every global object is a window.
Attachments
proposed fix (1.97 KB, patch)
2012-08-17 16:08 PDT, Alexey Proskuryakov 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-08-17 16:08:54 PDT
Created attachment 159220 [details] proposed fix
Sam Weinig
Comment 2 2012-08-17 16:15:44 PDT
Comment on attachment 159220 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=159220&action=review > Source/WebCore/bindings/js/JSDOMBinding.cpp:167 > + ScriptExecutionContext* scriptExecutionContext = globalObject->scriptExecutionContext(); > + scriptExecutionContext->reportException(ustringToString(errorMessage), lineNumber, ustringToString(exceptionSourceURL), 0); I think this can go on one line.
Alexey Proskuryakov
Comment 3 2012-08-17 16:28:12 PDT
Committed <http://trac.webkit.org/changeset/125946>.
Note You need to log in before you can comment on or make changes to this bug.