Bug 94381

Summary: Add ability to create AtomicString using LChar* buffer and length
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2012-08-17 14:04:24 PDT
Add an AtomicString::add() method that takes an LChar* and length. This would allow many Atomic string creation sites to use a native 8 bit string instead of up converting to 16 bits before creating.
Attachments
Patch (4.91 KB, patch)
2012-08-17 14:17 PDT, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-08-17 14:17:28 PDT
Created attachment 159201 [details] Patch
Geoffrey Garen
Comment 2 2012-08-17 14:19:25 PDT
Comment on attachment 159201 [details] Patch r=me Would be nice to explain what this improves.
Michael Saboff
Comment 3 2012-08-17 14:23:46 PDT
(In reply to comment #2) > (From update of attachment 159201 [details]) > r=me > > Would be nice to explain what this improves. This will be used initially in the 8 bit CSS parser path, but other places as well.
Michael Saboff
Comment 4 2012-08-17 17:43:48 PDT
Committed r125958: <http://trac.webkit.org/changeset/125958>
Note You need to log in before you can comment on or make changes to this bug.