Bug 94354

Summary: CSS Masking and CSS Filters applied in wrong order
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, dino, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dirk Schulze
Reported 2012-08-17 09:49:29 PDT
Looking at the RenderLayer code, I found a bug on the applying order of masking and filters. The Filter Effects spec say that the applying order is: filter, clipping, masking, opacity. In WebKit it is currently: clipping, masking, filters, opacity. So filters should be the first thing to do.
Attachments
Patch (17.50 KB, patch)
2012-08-18 12:36 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2012-08-17 21:39:33 PDT
Have a patch for that but need to write a test case first.
Dirk Schulze
Comment 2 2012-08-18 12:36:56 PDT
Created attachment 159267 [details] Patch
Simon Fraser (smfr)
Comment 3 2012-08-20 15:21:10 PDT
Do we get it right in composited mode?
Dirk Schulze
Comment 4 2012-08-20 15:22:02 PDT
I did not upload an explicit test for it, but yes, it does work with compositing mode.
WebKit Review Bot
Comment 5 2012-08-20 16:07:37 PDT
Comment on attachment 159267 [details] Patch Clearing flags on attachment: 159267 Committed r126084: <http://trac.webkit.org/changeset/126084>
WebKit Review Bot
Comment 6 2012-08-20 16:07:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.