Bug 94340

Summary: Remove RefPtr<Node>s from TextFieldInputType
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, eric, inferno, mifenton, morrita, rniwa, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94324    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-08-17 05:44:35 PDT
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324. TextFieldInputType::m_container, TextFieldInputType::m_innerBlock, TextFieldInputType::m_innerText, TextFieldInputType::m_placeholder, TextFieldInputType::m_speechButton and TextFieldInputType::m_innerSpinButton do not need to be RefPtr<Node>s, because they are guaranteed to point to the shadow DOM tree of the TextFieldInputType node, which is guaranteed to exist in the subtree of the TextFieldInputType node.
Attachments
Patch (8.88 KB, patch)
2012-08-17 05:46 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-17 05:46:58 PDT
Created attachment 159105 [details] Patch
Kent Tamura
Comment 2 2012-09-20 21:00:28 PDT
I'm very afraid this change causes security regressions. Text field code is really complex. So, I won't set r+ unless Bug 87815 is fixed and the patch uses ID access instead of raw pointers.
Kentaro Hara
Comment 3 2012-09-20 21:02:30 PDT
Comment on attachment 159105 [details] Patch OK. I'll clear r? because I also don't have a strong intention to land this patch.
Ryosuke Niwa
Comment 5 2022-08-17 12:37:48 PDT
We're not gonna do this.
Note You need to log in before you can comment on or make changes to this bug.