Bug 94339

Summary: Remove RefPtr from SearchInputType::m_resultsButton and SearchInputType::m_cancelButton
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, morrita, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94324    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-08-17 05:28:30 PDT
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324. SearchInputType::m_resultsButton and SearchInputType::m_cancelButton do not need to be RefPtr<Node>s, because they are guaranteed to point to the shadow DOM tree of the SearchInputType node, which is guaranteed to exist in the subtree of the SearchInputType node.
Attachments
Patch (4.43 KB, patch)
2012-08-17 05:30 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-17 05:30:47 PDT
Created attachment 159101 [details] Patch
Kent Tamura
Comment 2 2012-08-19 17:52:34 PDT
Comment on attachment 159101 [details] Patch ok
WebKit Review Bot
Comment 3 2012-08-19 18:08:21 PDT
Comment on attachment 159101 [details] Patch Clearing flags on attachment: 159101 Committed r125984: <http://trac.webkit.org/changeset/125984>
WebKit Review Bot
Comment 4 2012-08-19 18:08:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.