Bug 94336

Summary: Remove RefPtr from HTMLProgressElement::m_value
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94324    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-08-17 05:08:57 PDT
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324. HTMLProgressElement::m_value does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the HTMLProgressElement node, which is guaranteed to exist in the subtree of the HTMLProgressElement node.
Attachments
Patch (3.06 KB, patch)
2012-08-17 05:10 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-17 05:10:36 PDT
Created attachment 159093 [details] Patch
Kent Tamura
Comment 2 2012-08-19 17:50:30 PDT
Comment on attachment 159093 [details] Patch ok
WebKit Review Bot
Comment 3 2012-08-19 18:31:39 PDT
Comment on attachment 159093 [details] Patch Clearing flags on attachment: 159093 Committed r125985: <http://trac.webkit.org/changeset/125985>
WebKit Review Bot
Comment 4 2012-08-19 18:31:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.