Bug 94330

Summary:

Remove RefPtr from DateInputType::m_pickerElement

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

DOM

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, mifenton, morrita, peter+ews, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

94324

Attachments:

Description	Flags
Patch	peter+ews: commit-queue-
patch for landing	none

Kentaro Hara

Reported 2012-08-17 03:53:44 PDT

To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is describe in bug 94324. DateInputType::m_pickerElement does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the DateInputType node, which is guaranteed to exist in the subtree of the DateInputType node.

Attachments
Patch (3.06 KB, patch) 2012-08-17 03:58 PDT, Kentaro Hara	peter+ews: commit-queue-	Details Formatted Diff Diff
patch for landing (3.09 KB, patch) 2012-08-17 04:30 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-08-17 03:58:04 PDT

Created attachment 159076 [details] Patch

Kent Tamura

Comment 2 2012-08-17 04:04:02 PDT

Comment on attachment 159076 [details] Patch ok

Peter Beverloo (cr-android ews)

Comment 3 2012-08-17 04:04:16 PDT

Comment on attachment 159076 [details] Patch Attachment 159076 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13522102

Kentaro Hara

Comment 4 2012-08-17 04:30:00 PDT

Created attachment 159085 [details] patch for landing

WebKit Review Bot

Comment 5 2012-08-17 05:25:31 PDT

Comment on attachment 159085 [details] patch for landing Clearing flags on attachment: 159085 Committed r125886: <http://trac.webkit.org/changeset/125886>

Note You need to log in before you can comment on or make changes to this bug.