Bug 94309

Summary: DFG is still too pessimistic about what constitutes a side-effect on array accesses
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 91933    
Attachments:
Description Flags
the patch ggaren: review+

Description Filip Pizlo 2012-08-17 01:07:03 PDT 
The change to introduce PutByValSafe, and the change to eliminate the use of array predictions in selecting what kind of access to use, was not completely propagated to the structure check hoister or the CFA.
Comment 1 Filip Pizlo 2012-08-17 01:27:27 PDT 
Created attachment 159044 [details]
the patch
Comment 2 Geoffrey Garen 2012-08-17 14:16:08 PDT 
Comment on attachment 159044 [details]
the patch

r=me
Comment 3 Filip Pizlo 2012-08-17 17:57:30 PDT 
Landed in http://trac.webkit.org/changeset/125959