Bug 94294

Summary: Separate MarkStackThreadSharedData from MarkStack
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, gustavo, gyuyoung.kim, levin+threading, rakuco, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Hahnenberg
Reported 2012-08-16 22:22:29 PDT
MarkStackThreadSharedData is soon going to have data to allow for a parallel copying mode too, so to separate our concerns we should split it out into its own set of files and rename it to GCThreadSharedData. This is purely a cosmetic refactoring.
Attachments
Patch (20.67 KB, patch)
2012-08-16 22:24 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (33.34 KB, patch)
2012-08-22 11:34 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-08-16 22:24:31 PDT
Created attachment 158996 [details] Patch
Gustavo Noronha (kov)
Comment 2 2012-08-16 22:34:10 PDT
Comment on attachment 158996 [details] Patch Attachment 158996 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13513904
Gyuyoung Kim
Comment 3 2012-08-16 22:39:07 PDT
Comment on attachment 158996 [details] Patch Attachment 158996 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13510884
Early Warning System Bot
Comment 4 2012-08-16 22:47:14 PDT
Comment on attachment 158996 [details] Patch Attachment 158996 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13513908
Early Warning System Bot
Comment 5 2012-08-16 22:49:11 PDT
Comment on attachment 158996 [details] Patch Attachment 158996 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13520287
Build Bot
Comment 6 2012-08-16 23:03:37 PDT
Comment on attachment 158996 [details] Patch Attachment 158996 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13514665
Gyuyoung Kim
Comment 7 2012-08-16 23:05:03 PDT
Comment on attachment 158996 [details] Patch It looks GCThreadSharedData.cpp file wasn't added to this patch.
Build Bot
Comment 8 2012-08-17 03:57:02 PDT
Comment on attachment 158996 [details] Patch Attachment 158996 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13516748
Mark Hahnenberg
Comment 9 2012-08-22 11:34:54 PDT
Created attachment 159981 [details] Patch
Filip Pizlo
Comment 10 2012-08-22 14:25:19 PDT
rs=me.
WebKit Review Bot
Comment 11 2012-08-22 14:48:54 PDT
Comment on attachment 159981 [details] Patch Clearing flags on attachment: 159981 Committed r126354: <http://trac.webkit.org/changeset/126354>
WebKit Review Bot
Comment 12 2012-08-22 14:48:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.