Bug 94287

Summary: [Forms] Cleanup CSS selectors for multiple fields time input UI
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, macpherson, menard, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94196    
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-08-16 19:04:39 PDT
- Add margin left to spin button - Remove "width" selector - Use "em" instead of "px"
Attachments
Patch 1 (128.13 KB, patch)
2012-08-16 20:57 PDT, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-08-16 20:57:39 PDT
Created attachment 158987 [details] Patch 1
yosin
Comment 2 2012-08-16 20:59:09 PDT
Comment on attachment 158987 [details] Patch 1 Could you review this patch? Thanks in advance. Note: Tests are moved from bug 94196, which will contain only functional tests.
Kent Tamura
Comment 3 2012-08-16 21:07:52 PDT
Comment on attachment 158987 [details] Patch 1 Looks good.
yosin
Comment 4 2012-08-16 21:10:47 PDT
Comment on attachment 158987 [details] Patch 1 Clearing flags on attachment: 158987 Committed r125849: <http://trac.webkit.org/changeset/125849>
yosin
Comment 5 2012-08-16 21:10:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.