Bug 94282

Summary: Delete dead code in deprecated flexbox for RTL line-clamp
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, inferno, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ojan Vafai
Reported 2012-08-16 18:18:06 PDT
Delete dead code in deprecated flexbox for RTL line-clamp
Attachments
Patch (2.37 KB, patch)
2012-08-16 18:18 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-08-16 18:18:55 PDT
Created attachment 158964 [details] Patch
Tony Chang
Comment 2 2012-08-16 18:27:24 PDT
Comment on attachment 158964 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158964&action=review > Source/WebCore/ChangeLog:9 > + -webkit-line-clamp and direction:rtl is not supported. Delete some > + obviously dead code that half-tries to support it. Does this change cause a visible difference? It's probably OK if it does, but we should still have a test case to show it.
Ojan Vafai
Comment 3 2012-08-16 18:39:08 PDT
Comment on attachment 158964 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158964&action=review >> Source/WebCore/ChangeLog:9 >> + obviously dead code that half-tries to support it. > > Does this change cause a visible difference? It's probably OK if it does, but we should still have a test case to show it. No. It's actually just deleting dead code. If you look like 3 lines above you can see that leftToRight is always true.
WebKit Review Bot
Comment 4 2012-08-17 13:42:41 PDT
Comment on attachment 158964 [details] Patch Clearing flags on attachment: 158964 Committed r125929: <http://trac.webkit.org/changeset/125929>
WebKit Review Bot
Comment 5 2012-08-17 13:42:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.