Bug 94282

Summary: Delete dead code in deprecated flexbox for RTL line-clamp
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, inferno, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ojan Vafai 2012-08-16 18:18:06 PDT
Delete dead code in deprecated flexbox for RTL line-clamp
Comment 1 Ojan Vafai 2012-08-16 18:18:55 PDT
Created attachment 158964 [details]
Patch
Comment 2 Tony Chang 2012-08-16 18:27:24 PDT
Comment on attachment 158964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158964&action=review

> Source/WebCore/ChangeLog:9
> +        -webkit-line-clamp and direction:rtl is not supported. Delete some
> +        obviously dead code that half-tries to support it.

Does this change cause a visible difference?  It's probably OK if it does, but we should still have a test case to show it.
Comment 3 Ojan Vafai 2012-08-16 18:39:08 PDT
Comment on attachment 158964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158964&action=review

>> Source/WebCore/ChangeLog:9
>> +        obviously dead code that half-tries to support it.
> 
> Does this change cause a visible difference?  It's probably OK if it does, but we should still have a test case to show it.

No. It's actually just deleting dead code. If you look like 3 lines above you can see that leftToRight is always true.
Comment 4 WebKit Review Bot 2012-08-17 13:42:41 PDT
Comment on attachment 158964 [details]
Patch

Clearing flags on attachment: 158964

Committed r125929: <http://trac.webkit.org/changeset/125929>
Comment 5 WebKit Review Bot 2012-08-17 13:42:48 PDT
All reviewed patches have been landed.  Closing bug.