| Summary: | [chromium] Add Source/WebCore/platform/graphics/chromium/cc/ to include path and remove cc/ prefix from includes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, enne, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2012-08-16 18:07:19 PDT
Created attachment 158962 [details]
Patch
This patch is mostly generated from sed, plus resorting the include sections. The problem this solves is that when the compositor code lands in (chromium)/cc, it'll be on the include path for everybody whether they want it or not. With this we can control the include path explicitly with gyp to control whether people see the code in WC/platform/graphics/chromium/cc/ or code in the chromium repo. Comment on attachment 158962 [details]
Patch
rs=me
Comment on attachment 158962 [details] Patch Rejecting attachment 158962 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /tests/TiledLayerChromiumTest.cpp patching file Source/WebKit/chromium/tests/TreeSynchronizerTest.cpp patching file Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp patching file Source/WebKit/chromium/tests/WebFloatAnimationCurveTest.cpp patching file Source/WebKit/chromium/tests/WebTransformAnimationCurveTest.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13516603 Committed r125932: <http://trac.webkit.org/changeset/125932> |