Bug 94269

Summary: IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when setting version
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, jsbell, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

David Grogan
Reported 2012-08-16 16:49:48 PDT
IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when setting version
Attachments
Patch (3.08 KB, patch)
2012-08-16 16:54 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.11 KB, patch)
2012-08-17 14:37 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-08-16 16:54:09 PDT
Created attachment 158945 [details] Patch
David Grogan
Comment 2 2012-08-16 17:12:33 PDT
Alec, could you look at this? It looks like Josh had similar suspicions, as his patch in https://bugs.webkit.org/attachment.cgi?id=158936&action=review#line228 changes this to ASSERT(ok).
Alec Flett
Comment 3 2012-08-17 13:59:45 PDT
Comment on attachment 158945 [details] Patch lgtm
David Grogan
Comment 4 2012-08-17 14:05:03 PDT
Ojan, could you review this 5-liner?
Ojan Vafai
Comment 5 2012-08-17 14:14:25 PDT
Comment on attachment 158945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158945&action=review > Source/WebCore/ChangeLog:13 > + is not hit after a while, change it to ASSERT(ok). By ASSERT(ok), do you mean ASSERT(transaction.scheduleTask(...))?
David Grogan
Comment 6 2012-08-17 14:37:12 PDT
Created attachment 159207 [details] Patch for landing
David Grogan
Comment 7 2012-08-17 14:37:28 PDT
Comment on attachment 158945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158945&action=review Thanks for the review. >> Source/WebCore/ChangeLog:13 >> + is not hit after a while, change it to ASSERT(ok). > > By ASSERT(ok), do you mean ASSERT(transaction.scheduleTask(...))? Yes, changed.
WebKit Review Bot
Comment 8 2012-08-17 16:11:38 PDT
Comment on attachment 159207 [details] Patch for landing Clearing flags on attachment: 159207 Committed r125943: <http://trac.webkit.org/changeset/125943>
WebKit Review Bot
Comment 9 2012-08-17 16:11:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.