Bug 94241 – Frame bytes should be determined by platform image decoder

• Component: Images
• Status: RESOLVED FIXED

[Hin-Chung Lam]

BitmapImage assumes the cached size is always width * height * 4. For platforms that implement deferred image decoding or have platform image backed by a texture would use no system memory. For these cases it is best to query the platform image decoder to determine the frame size such that these frames are not managed by WebKit's memory cached.

[Hin-Chung Lam]

Created attachment 158914 [details]
Patch

[Hin-Chung Lam]

Created attachment 158917 [details]
Patch

[Build Bot]

Comment on attachment 158917 [details]
Patch

Attachment 158917 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13514553

[Hin-Chung Lam]

Created attachment 158966 [details]
Patch

[Dongseong Hwang]

(In reply to comment #4)
> Created an attachment (id=158966) [details]
> Patch

> Source/WebCore/platform/image-decoders/ImageDecoder.cpp
> 294    return m_size.width() * m_size.height() * 4;

You can use IntSize::area(). How about m_size.area() * sizeof(PixelData)?

[Hin-Chung Lam]

Created attachment 159497 [details]
Patch

[WebKit Review Bot]

Comment on attachment 159497 [details]
Patch

Clearing flags on attachment: 159497

Committed r126892: <http://trac.webkit.org/changeset/126892>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.