Bug 94207

Summary: DirectoryEntry should use Dictionary rather than custom bindings code
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, ericu, eric, gyuyoung.kim, haraken, japhet, ojan, peter+ews, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
work in progress
none
work in progress
none
Patch none

Description Adam Barth 2012-08-16 01:54:34 PDT
DirectoryEntry should use Dictionary rather than custom bindings code
Comment 1 Adam Barth 2012-08-16 01:56:02 PDT
Created attachment 158752 [details]
work in progress
Comment 2 Adam Barth 2012-08-16 01:57:22 PDT
Created attachment 158753 [details]
work in progress
Comment 3 WebKit Review Bot 2012-08-16 02:40:48 PDT
Attachment 158753 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/Modules/filesystem/WebKitFlags.h:31:  #ifndef header guard has wrong style, please use: WebKitFlags_h  [build/header_guard] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Peter Beverloo (cr-android ews) 2012-08-16 02:48:29 PDT
Comment on attachment 158753 [details]
work in progress

Attachment 158753 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13504920
Comment 5 Eric Seidel (no email) 2012-08-16 02:53:29 PDT
Sorry, I made a mess of your bug. :(
Comment 6 WebKit Review Bot 2012-08-16 02:59:12 PDT
Comment on attachment 158753 [details]
work in progress

Attachment 158753 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13516315
Comment 7 Adam Barth 2012-08-16 09:40:57 PDT
> Sorry, I made a mess of your bug. :(

It's ok.  Yeah, this patch isn't done.  I just wanted to post it before heading to bed do I didn't lose it.
Comment 8 Adam Barth 2012-08-16 11:49:11 PDT
Created attachment 158866 [details]
Patch
Comment 9 Eric Seidel (no email) 2012-08-16 13:26:46 PDT
Comment on attachment 158866 [details]
Patch

LGTM.
Comment 10 WebKit Review Bot 2012-08-16 13:44:54 PDT
Comment on attachment 158866 [details]
Patch

Clearing flags on attachment: 158866

Committed r125807: <http://trac.webkit.org/changeset/125807>
Comment 11 WebKit Review Bot 2012-08-16 13:45:01 PDT
All reviewed patches have been landed.  Closing bug.