Bug 94207

Summary:

DirectoryEntry should use Dictionary rather than custom bindings code

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, ericu, eric, gyuyoung.kim, haraken, japhet, ojan, peter+ews, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
work in progress	none
work in progress	none
Patch	none

Adam Barth

Reported 2012-08-16 01:54:34 PDT

DirectoryEntry should use Dictionary rather than custom bindings code

Attachments
work in progress (33.00 KB, patch) 2012-08-16 01:56 PDT, Adam Barth	no flags	Details Formatted Diff Diff
work in progress (32.95 KB, patch) 2012-08-16 01:57 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch (65.77 KB, patch) 2012-08-16 11:49 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2012-08-16 01:56:02 PDT

Created attachment 158752 [details] work in progress

Adam Barth

Comment 2 2012-08-16 01:57:22 PDT

Created attachment 158753 [details] work in progress

WebKit Review Bot

Comment 3 2012-08-16 02:40:48 PDT

Attachment 158753 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/Modules/filesystem/WebKitFlags.h:31: #ifndef header guard has wrong style, please use: WebKitFlags_h [build/header_guard] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Peter Beverloo (cr-android ews)

Comment 4 2012-08-16 02:48:29 PDT

Comment on attachment 158753 [details] work in progress Attachment 158753 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13504920

Eric Seidel (no email)

Comment 5 2012-08-16 02:53:29 PDT

Sorry, I made a mess of your bug. :(

WebKit Review Bot

Comment 6 2012-08-16 02:59:12 PDT

Comment on attachment 158753 [details] work in progress Attachment 158753 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13516315

Adam Barth

Comment 7 2012-08-16 09:40:57 PDT

> Sorry, I made a mess of your bug. :( It's ok. Yeah, this patch isn't done. I just wanted to post it before heading to bed do I didn't lose it.