Bug 94180

Summary: TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING.
Product: WebKit Reporter: Zhigang Gong <zhigang.gong>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zhigang Gong
Reported 2012-08-15 20:36:53 PDT
TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING.
Attachments
Patch (1.73 KB, patch)
2012-08-15 20:37 PDT, Zhigang Gong 		no flags
DetailsFormatted DiffDiff
Patch (1.54 KB, patch)
2012-08-15 23:00 PDT, Zhigang Gong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhigang Gong
Comment 1 2012-08-15 20:37:30 PDT
Created attachment 158701 [details] Patch
WebKit Review Bot
Comment 2 2012-08-15 22:46:41 PDT
Comment on attachment 158701 [details] Patch Rejecting attachment 158701 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13511425
Zhigang Gong
Comment 3 2012-08-15 23:00:23 PDT
Created attachment 158715 [details] Patch
WebKit Review Bot
Comment 4 2012-08-15 23:08:41 PDT
Comment on attachment 158715 [details] Patch Rejecting attachment 158715 [details] from commit-queue. zhigang.gong@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Zhigang Gong
Comment 5 2012-08-15 23:19:24 PDT
Hi Noam, As the previous patch has OOPS and caused the build fail, I resubmitted a new version, Could you help to review the new version again. Thanks.
WebKit Review Bot
Comment 6 2012-08-16 00:19:01 PDT
Comment on attachment 158715 [details] Patch Clearing flags on attachment: 158715 Committed r125752: <http://trac.webkit.org/changeset/125752>
WebKit Review Bot
Comment 7 2012-08-16 00:19:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.