Bug 94154

Summary: [chromium] Replace destRect with destOffset in texture upload
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: aelias, cc-bugs, dglazkov, enne, eric.carlson, feature-media-reviews, jamesr, peter+ews, piman, reveman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alexandre Elias
Reported 2012-08-15 15:19:09 PDT
[chromium] Replace destRect with destOffset in texture upload
Attachments
Patch (44.43 KB, patch)
2012-08-15 15:24 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (45.70 KB, patch)
2012-08-15 16:59 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2012-08-15 15:24:06 PDT
Created attachment 158649 [details] Patch
Alexandre Elias
Comment 2 2012-08-15 15:26:15 PDT
This is just a small cleanup for a problem that I encountered while writing the software texture upload implementation. I realized the GL implementation doesn't properly support destRect either, so we should just remove it from the interface.
James Robinson
Comment 3 2012-08-15 15:35:32 PDT
Comment on attachment 158649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158649&action=review > Source/WebCore/ChangeLog:13 > + "IntRect destRect" by "IntPoint destOffset". According to the WebCore geometry system, offsets should be represented by IntSize, not IntPoint. Mind search-replacing the type before landing?
WebKit Review Bot
Comment 4 2012-08-15 15:51:36 PDT
Comment on attachment 158649 [details] Patch Attachment 158649 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13504733
Peter Beverloo (cr-android ews)
Comment 5 2012-08-15 16:35:52 PDT
Comment on attachment 158649 [details] Patch Attachment 158649 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13517141
Alexandre Elias
Comment 6 2012-08-15 16:59:00 PDT
Created attachment 158663 [details] Patch
Alexandre Elias
Comment 7 2012-08-15 16:59:47 PDT
Done, although I'd suggest changing the policy during the transition to gfx:: types, since I don't think it makes any sense.
WebKit Review Bot
Comment 8 2012-08-16 16:43:45 PDT
Comment on attachment 158663 [details] Patch Clearing flags on attachment: 158663 Committed r125827: <http://trac.webkit.org/changeset/125827>
WebKit Review Bot
Comment 9 2012-08-16 16:43:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.