Bug 94140

Summary: Remove StyleSheetContents::m_finalURL
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, kling, macpherson, menard, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-04
none
patch
webkit.review.bot: commit-queue-
another
webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-08
none
try to fix chromium serializer test none

Description Antti Koivisto 2012-08-15 13:32:33 PDT
It is always the same as baseURL().
Comment 1 Antti Koivisto 2012-08-15 13:40:11 PDT
Created attachment 158630 [details]
patch
Comment 2 Andreas Kling 2012-08-15 13:43:24 PDT
Comment on attachment 158630 [details]
patch

r=me, though please consider removing the actual variable too.
Comment 3 Antti Koivisto 2012-08-15 14:03:44 PDT
(In reply to comment #2)
> (From update of attachment 158630 [details])
> r=me, though please consider removing the actual variable too.

An excellent idea!
Comment 4 WebKit Review Bot 2012-08-15 14:32:46 PDT
Comment on attachment 158630 [details]
patch

Attachment 158630 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13509333

New failing tests:
WebPageNewSerializeTest.FAILS_TestMHTMLEncoding
http/tests/security/data-url-inline.css.html
WebPageNewSerializeTest.FAILS_CSSResources
Comment 5 WebKit Review Bot 2012-08-15 14:32:50 PDT
Created attachment 158637 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 6 Antti Koivisto 2012-08-16 05:36:37 PDT
Created attachment 158785 [details]
patch
Comment 7 WebKit Review Bot 2012-08-16 05:48:51 PDT
Comment on attachment 158785 [details]
patch

Attachment 158785 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13513548
Comment 8 Peter Beverloo (cr-android ews) 2012-08-16 05:49:34 PDT
Comment on attachment 158785 [details]
patch

Attachment 158785 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13514359
Comment 9 Early Warning System Bot 2012-08-16 06:04:21 PDT
Comment on attachment 158785 [details]
patch

Attachment 158785 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13518147
Comment 10 Gyuyoung Kim 2012-08-16 06:09:38 PDT
Comment on attachment 158785 [details]
patch

Attachment 158785 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13506715
Comment 11 Early Warning System Bot 2012-08-16 06:11:25 PDT
Comment on attachment 158785 [details]
patch

Attachment 158785 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13506714
Comment 12 Build Bot 2012-08-16 06:28:46 PDT
Comment on attachment 158785 [details]
patch

Attachment 158785 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13517339
Comment 13 Antti Koivisto 2012-08-16 06:46:22 PDT
Created attachment 158801 [details]
another
Comment 14 WebKit Review Bot 2012-08-16 07:41:31 PDT
Comment on attachment 158801 [details]
another

Attachment 158801 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13512486

New failing tests:
WebPageNewSerializeTest.FAILS_TestMHTMLEncoding
WebPageNewSerializeTest.FAILS_CSSResources
Comment 15 WebKit Review Bot 2012-08-16 07:41:35 PDT
Created attachment 158818 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 16 Antti Koivisto 2012-08-16 11:36:05 PDT
Created attachment 158864 [details]
try to fix chromium serializer test
Comment 17 Antti Koivisto 2012-08-16 13:30:45 PDT
http://trac.webkit.org/changeset/125805