Summary: | win64 compile error fix for BinaryPropertyList.cpp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <alex.christensen> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
Attachments: |
|
Description
Alex Christensen
2012-08-15 10:33:32 PDT
Created attachment 158589 [details]
Patch
Comment on attachment 158589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158589&action=review I think the intent of this change is good, but please switch to the more explicit C++-style cast; I think this is just a static_cast<>. > Source/WebCore/platform/cf/BinaryPropertyList.cpp:700 > + appendByte((unsigned char)(asciiStringMarkerByte | length)); We use C++-style casts in the Coding Guideline: static_cast<unsigned char>(asciiStringMarkerByte | length) > Source/WebCore/platform/cf/BinaryPropertyList.cpp:709 > + appendByte((unsigned char)(unicodeStringMarkerByte | length)); Ditto. > Source/WebCore/platform/cf/BinaryPropertyList.cpp:726 > + appendByte((unsigned char)(asciiStringMarkerByte | length)); Ditto Created attachment 158855 [details]
patch
Comment on attachment 158855 [details] patch Clearing flags on attachment: 158855 Committed r126357: <http://trac.webkit.org/changeset/126357> All reviewed patches have been landed. Closing bug. |