Bug 94117

Summary:

[BlackBerry] Use nested layout when rotating

Product:

WebKit

Reporter:

Leo Yang <leo.yang>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mifenton, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch v2	none

Description Leo Yang 2012-08-15 08:41:55 PDT

RIM PR #181548
When rotating the content with used for layout is not correct. We need to use nested layout to re-determine the final layout.

Comment 1 Leo Yang 2012-08-15 08:47:22 PDT

Created attachment 158574 [details]
Patch

Comment 2 WebKit Review Bot 2012-08-15 08:49:48 PDT

Attachment 158574 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:2524:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Leo Yang 2012-08-15 08:51:41 PDT

Created attachment 158575 [details]
Patch v2

Comment 4 WebKit Review Bot 2012-08-15 09:20:55 PDT

Comment on attachment 158575 [details]
Patch v2

Clearing flags on attachment: 158575

Committed r125680: <http://trac.webkit.org/changeset/125680>

Comment 5 WebKit Review Bot 2012-08-15 09:20:58 PDT

All reviewed patches have been landed.  Closing bug.