Bug 94113

Summary: VCSUtils.pm: git log --grep='git-svn-id: ' fails on Windows
Product: WebKit Reporter: Kevin Funk <kevin.funk>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jturcotte, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 none

Kevin Funk
Reported 2012-08-15 07:51:50 PDT
Title says it all. Need to enquote the string with "" instead. Patch attached.
Attachments
Patch (965 bytes, patch)
2012-08-15 07:52 PDT, Kevin Funk 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.58 KB, patch)
2012-08-15 08:05 PDT, Kevin Funk 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kevin Funk
Comment 1 2012-08-15 07:52:23 PDT
Created attachment 158569 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-08-15 07:55:04 PDT
Could you create a "proper" patch, ie. follow the project guidelines, and include a changelog entry. Use the script Tools/Scripts/prepare-ChangeLog to get started :-)
Kevin Funk
Comment 3 2012-08-15 08:05:15 PDT
Created attachment 158570 [details] Patch v2
WebKit Review Bot
Comment 4 2012-08-15 08:47:02 PDT
Comment on attachment 158570 [details] Patch v2 Clearing flags on attachment: 158570 Committed r125675: <http://trac.webkit.org/changeset/125675>
WebKit Review Bot
Comment 5 2012-08-15 08:47:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.