Bug 94113

Summary:

VCSUtils.pm: git log --grep='git-svn-id: ' fails on Windows

Product:

WebKit

Reporter:

Kevin Funk <kevin.funk>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jturcotte, kenneth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch v2	none

Description Kevin Funk 2012-08-15 07:51:50 PDT

Title says it all. Need to enquote the string with "" instead.

Patch attached.

Comment 1 Kevin Funk 2012-08-15 07:52:23 PDT

Created attachment 158569 [details]
Patch

Comment 2 Kenneth Rohde Christiansen 2012-08-15 07:55:04 PDT

Could you create a "proper" patch, ie. follow the project guidelines, and include a changelog entry. Use the script Tools/Scripts/prepare-ChangeLog to get started :-)

Comment 3 Kevin Funk 2012-08-15 08:05:15 PDT

Created attachment 158570 [details]
Patch v2

Comment 4 WebKit Review Bot 2012-08-15 08:47:02 PDT

Comment on attachment 158570 [details]
Patch v2

Clearing flags on attachment: 158570

Committed r125675: <http://trac.webkit.org/changeset/125675>

Comment 5 WebKit Review Bot 2012-08-15 08:47:06 PDT

All reviewed patches have been landed.  Closing bug.