| Summary: | [css3-text] Add getComputedStyle tests for -webkit-text-decoration-line | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bruno Abinader (history only) <bruno.abinader> | ||||||||||||
| Component: | CSS | Assignee: | Bruno Abinader (history only) <bruno.abinader> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Enhancement | CC: | ap, gustavo, gyuyoung.kim, igor.oliveira, jchaffraix, noam, rakuco, vestbo, webkit.review.bot, xan.lopez | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 90959, 93863, 94093 | ||||||||||||||
| Bug Blocks: | 58491 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Bruno Abinader (history only)
2012-08-15 07:18:07 PDT
Created attachment 158565 [details]
Patch
Proposed patch.
Created attachment 159111 [details] Patch (EWS run only) This patch adds changes to make CSS3_TEXT_DECORATION feature flag enabled and remove skip of fast/css3-text-decoration layout test directory from chromium build. This is intentional to get EWS results, but not intended for landing (as suggested by Peter Beverloo in http://lists.webkit.org/pipermail/webkit-dev/2012-August/021925.html ). It is not intended for landing, but acts as a workaround to get proper EWS results for the previous patch. Comment on attachment 159111 [details] Patch (EWS run only) Attachment 159111 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13516803 (In reply to comment #3) > (From update of attachment 159111 [details]) > Attachment 159111 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/13516803 It appears that some platform builds doesn't handle fall-through switch cases inside #ifdef's well :/ Both builds are failing because of this: ... case CSSPropertyTextDecoration: #if ENABLE(CSS3_TEXT_DECORATION) case CSSPropertyWebkitTextDecorationLine: #endif // CSS3_TEXT_DECORATION return renderTextDecorationFlagsToCSSValue(style->textDecoration()); ... Fortunately this is fixed on patch from bug 94093 ( https://bugs.webkit.org/attachment.cgi?id=158567&action=diff#a/Source/WebCore/css/CSSComputedStyleDeclaration.cpp_sec3 ), so I wouldn't consider these failures for now. Comment on attachment 159111 [details] Patch (EWS run only) Attachment 159111 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13514839 Comment on attachment 159111 [details] Patch (EWS run only) Attachment 159111 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13528093 Adding bug 94093 as dependency (fixes build on gtk, mac and win platforms). Created attachment 159411 [details]
Patch
Updated layout tests missing corner cases and readibility.
Comment on attachment 159411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159411&action=review > LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html:1 > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> <!DOCTYPE html> according to http://www.w3.org/TR/html5/syntax.html#the-doctype Created attachment 159414 [details]
Patch
Fixed DOCTYPE tag as pointed by Kenneth.
Created attachment 159485 [details]
Patch
Updated "Reviewed by" ChangeLog section.
Comment on attachment 159485 [details] Patch Clearing flags on attachment: 159485 Committed r126060: <http://trac.webkit.org/changeset/126060> Comment on attachment 159411 [details]
Patch
Clearing cq flags, as this patch has landed already.
|