Summary: | [EFL][WK2] Add unit tests for WKEinaSharedString | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 90451 | ||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-08-15 06:51:15 PDT
Created attachment 159369 [details]
patch
Comment on attachment 159369 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=159369&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:42 > +static const char testString[] = "I'm test string!"; > +static const char anotherTestString[] = "I'm another test string!"; Why not make two alike here? Created attachment 159388 [details]
patch v2
Use always different string objects.
Comment on attachment 159388 [details] patch v2 Clearing flags on attachment: 159388 Committed r126019: <http://trac.webkit.org/changeset/126019> All reviewed patches have been landed. Closing bug. |