Bug 94104

Summary: [EFL][WK2] Add unit tests for WKEinaSharedString
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90451    
Description Flags
kenneth: review+
patch v2 none

Description Mikhail Pozdnyakov 2012-08-15 06:51:15 PDT
Unit tests for WKEinaSharedString are to be added.
Comment 1 Mikhail Pozdnyakov 2012-08-20 01:52:16 PDT
Created attachment 159369 [details]
Comment 2 Kenneth Rohde Christiansen 2012-08-20 01:57:55 PDT
Comment on attachment 159369 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=159369&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:42
> +static const char testString[] = "I'm test string!";
> +static const char anotherTestString[] = "I'm another test string!";

Why not make two alike here?
Comment 3 Mikhail Pozdnyakov 2012-08-20 03:38:24 PDT
Created attachment 159388 [details]
patch v2

Use always different string objects.
Comment 4 WebKit Review Bot 2012-08-20 04:52:42 PDT
Comment on attachment 159388 [details]
patch v2

Clearing flags on attachment: 159388

Committed r126019: <http://trac.webkit.org/changeset/126019>
Comment 5 WebKit Review Bot 2012-08-20 04:52:47 PDT
All reviewed patches have been landed.  Closing bug.