Bug 94098

Summary:

Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-06	none

Vsevolod Vlasov

Reported 2012-08-15 05:57:10 PDT

The reason is that we unconditionally clear TabbedEditorContainer's _currentFile field when tab is closed. Patch to follow.

Attachments
Patch (2.03 KB, patch) 2012-08-15 06:03 PDT, Vsevolod Vlasov	pfeldman: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-06 (430.88 KB, application/zip) 2012-08-15 06:39 PDT, WebKit Review Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2012-08-15 06:03:38 PDT

Created attachment 158554 [details] Patch

WebKit Review Bot

Comment 2 2012-08-15 06:39:47 PDT

Comment on attachment 158554 [details] Patch Attachment 158554 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13501647 New failing tests: inspector/debugger/scripts-panel.html

WebKit Review Bot

Comment 3 2012-08-15 06:39:51 PDT

Created attachment 158560 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Vsevolod Vlasov

Comment 4 2012-08-15 06:54:13 PDT

Committed r125672: <http://trac.webkit.org/changeset/125672>

Note You need to log in before you can comment on or make changes to this bug.