Bug 94085

Summary: Cancel the outstanding vibration pattern if the pattern is 0 or an empty list
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: DOMAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, kenneth, kihong.kwon, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-08-15 01:43:23 PDT
We must cancel the outstanding vibration pattern (i.e stop the device from vibrating), if the pattern is 0 or an empty list.
Attachments
Patch (1.58 KB, patch)
2012-08-15 02:11 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2012-08-15 04:14 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (1.96 KB, patch)
2012-08-20 16:12 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-08-15 02:11:13 PDT
Created attachment 158529 [details] Patch
Kihong Kwon
Comment 2 2012-08-15 02:41:57 PDT
Looks fine to me. But, IMHO we need more detail description. It's hard to understand why you change vibrate logic like this.
Sudarsana Nagineni (babu)
Comment 3 2012-08-15 04:14:18 PDT
Created attachment 158543 [details] Patch Thanks for the informal review Kihong. Updated changelog now.
Kenneth Rohde Christiansen
Comment 4 2012-08-15 06:29:18 PDT
Comment on attachment 158543 [details] Patch Can we please have a test for this?
Sudarsana Nagineni (babu)
Comment 5 2012-08-15 06:46:39 PDT
Kenneth, thanks for looking into this. Unfortunately there is no return value in the Vibration API to check status. Same issue was discussed in bug 93957, comment 4.
Kenneth Rohde Christiansen
Comment 6 2012-08-15 06:47:36 PDT
Can't you do some private hooks for testing?
Sudarsana Nagineni (babu)
Comment 7 2012-08-15 07:52:51 PDT
(In reply to comment #6) > Can't you do some private hooks for testing? I have no clue about this, but what I'm planning to do next is write unit tests for the API (in bug 93890) and make sure that vibrate/cancel callabcks are getting called correctly and the implementation is fully compliant with the spec.
Sudarsana Nagineni (babu)
Comment 8 2012-08-17 09:01:11 PDT
EFL WK2 port has unit tests(landed in r125893) for the Vibration API now to verify the implementation.
Sudarsana Nagineni (babu)
Comment 9 2012-08-20 16:12:35 PDT
Created attachment 159554 [details] Patch Rebased and updated changelog.
Kentaro Hara
Comment 10 2012-08-20 16:34:35 PDT
Comment on attachment 159554 [details] Patch The change looks reasonable. We wanted any test, but it would be OK for now based on the following comment. > EFL WK2 port has unit tests(landed in r125893) for the Vibration API now to verify the implementation.
WebKit Review Bot
Comment 11 2012-08-20 18:50:31 PDT
Comment on attachment 159554 [details] Patch Clearing flags on attachment: 159554 Committed r126116: <http://trac.webkit.org/changeset/126116>
WebKit Review Bot
Comment 12 2012-08-20 18:50:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.