Bug 94070
| Summary: | [CSS Regions] broken feature detection: syntax parsing succeeds when ENABLE_CSS_REGIONS is false | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Paul Irish <paulirish> |
| Component: | CSS | Assignee: | Mihai Maerean <mmaerean> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | divya, donggwan.kim, mibalan, mihnea, mmaerean, morrita, rhudea, WebkitBugTracker |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 101192 | ||
| Bug Blocks: | 57312 | ||
Paul Irish
1. If CSS Regions is not enabled (it's turned off in about:flags in Chrome) then the following should be true
document.body.style.webkitRegionOverflow == undefined
Currently it'll return an empty string.
2. Additionally, in http://adobe.github.com/web-platform/utilities/css-regions-support-matrix/
One of the assertions ('Initial default value for region-overflow') will pass in Chrome Canary with the flag turned off. Chrome should score a 0 with the feature turned off.
3. With this fixed, feature detects would fail fast:
https://github.com/Modernizr/Modernizr/blob/b18048b4b4245326d7f6f5a998df58050acf51a9/feature-detects/css-regions.js#L12-17
4. More importantly, this may end up being a false positive in the upcoming @supports functionality (bug 86146)
Thanks!
(Feel free to rename ticket if I've gotten the details wrong)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Hajime Morrita
*** Bug 98884 has been marked as a duplicate of this bug. ***
Michelangelo De Simone
This seems to be a Chromium bug, closing.
Mihai Balan
The bug actually has some WebKit ramifications, too.
Keeping it open.
Mihai Balan
Since Regions are enabled by default in Safari, will close as RESOLVED/INVALID