Summary: | Update test expectations for css3/filters/custom/invalid-custom-filter-shader.html failing on Apple Lion Debug WK1 (Tests) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kiran Muppala <cmuppala> | ||||||
Component: | Tools / Tests | Assignee: | Kiran Muppala <cmuppala> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmuppala, fmalita, krit, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | LayoutTestFailure | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kiran Muppala
2012-08-14 21:23:24 PDT
Created attachment 158498 [details]
Patch
The image diff is expected as filters are now applied in a different color space by default, so it should be fine to mark it for rebaseline instead of regression. Quite a few tests need rebaselining (see the BUGWK6033 lines in TestExpectations), but the original patch missed this particular one. Thanks for catching it. Created attachment 158655 [details]
Patch
Attached patch to add css3/filters/custom/invalid-custom-filter-shader.html to the list of test needing re-baselining after https://bugs.webkit.org/show_bug.cgi?id=6033 Comment on attachment 158655 [details] Patch Rejecting attachment 158655 [details] from commit-queue. cmuppala@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 158655 [details] Patch Clearing flags on attachment: 158655 Committed r125731: <http://trac.webkit.org/changeset/125731> All reviewed patches have been landed. Closing bug. |