Bug 94062

Summary: Web Inspector: Implement context menus in CodeMirrorTextEditor
Product: WebKit Reporter: Jan Keromnes <janx>
Component: Web Inspector (Deprecated)Assignee: Jan Keromnes <janx>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 99319    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Jan Keromnes
Reported 2012-08-14 19:32:59 PDT
Currently CodeMirrorTextEditor doesn't populate context menus the way DefaultTextEditor does. We should implement them and make sure that exposed features work as expected.
Attachments
Patch (2.45 KB, patch)
2012-12-02 11:17 PST, Jan Keromnes 		no flags
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2012-12-03 10:05 PST, Jan Keromnes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Keromnes
Comment 1 2012-12-02 11:17:18 PST
Created attachment 177143 [details] Patch
Jan Keromnes
Comment 2 2012-12-02 11:22:00 PST
A patch to add a contextmenu handler to the CodeMirror editor. Similarly to DefaultTextEditor's _contextMenu, it handles text body and gutter differently, and for the latter it determines the corresponding line number. This adds back UI controls for disabling / conditional breakpoints.
Pavel Feldman
Comment 3 2012-12-03 09:52:28 PST
Comment on attachment 177143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177143&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:60 > + this._codeMirror.getWrapperElement().addEventListener("contextmenu", this._contextMenu.bind(this)); does getWrapperElement return this.element?
Jan Keromnes
Comment 4 2012-12-03 10:05:32 PST
Created attachment 177279 [details] Patch
Jan Keromnes
Comment 5 2012-12-03 10:11:21 PST
(In reply to comment #3) > does getWrapperElement return this.element? Right, sorry about that.
WebKit Review Bot
Comment 6 2012-12-03 10:45:04 PST
Comment on attachment 177279 [details] Patch Clearing flags on attachment: 177279 Committed r136414: <http://trac.webkit.org/changeset/136414>
WebKit Review Bot
Comment 7 2012-12-03 10:45:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.