Bug 94060 – [Chromium] fast/dom/Window/dom-access-from-closure-window.html is flaky on Linux

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Yuta Kitamura]

The following test is flaky on Chromium-Linux bots:

fast/dom/Window/dom-access-from-closure-window.html

Looks like http://trac.webkit.org/changeset/125592 fixed the issue which caused this test to fail consistently, but it introduced a new flakiness (or revealed the hidden flakiness).
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FWindow%2Fdom-access-from-closure-window.html

It seems Mac and Windows are okay at this moment.

Diffs look like the following:

--- /b/build/slave/Webkit_Linux__dbg_/build/layout-test-results/fast/dom/Window/dom-access-from-closure-window-expected.txt 
+++ /b/build/slave/Webkit_Linux__dbg_/build/layout-test-results/fast/dom/Window/dom-access-from-closure-window-actual.txt 
@@ -1,5 +1,4 @@
-document.URL: LayoutTests/fast/dom/Window/resources/dom-access-from-closure-window-child.html
-window.document.URL: LayoutTests/fast/dom/Window/resources/notify-opener-done.html
-name: child
-window.name: child
+CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL notify-opener-done.html. Domains, protocols and ports must match.
 
+An exception was thrown: Cannot read property 'URL' of undefined
+

[Adam Barth]

Thanks.  This does sound related to my patch.

[Adam Barth]

The flakiness seems to be gc-dependent.  If you call gc() as the first statement in done(), you can repro 100% of the time.

[Adam Barth]

Created attachment 158509 [details]
Need to check JSC

[Adam Barth]

Created attachment 158515 [details]
Patch

[Kentaro Hara]

Comment on attachment 158515 [details]
Patch

Looks reasonable.

[WebKit Review Bot]

Comment on attachment 158515 [details]
Patch

Clearing flags on attachment: 158515

Committed r125656: <http://trac.webkit.org/changeset/125656>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.