Summary: | [Chromium] fast/dom/Window/dom-access-from-closure-window.html is flaky on Linux | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuta Kitamura <yutak> | ||||||
Component: | Tools / Tests | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, haraken, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Yuta Kitamura
2012-08-14 19:29:57 PDT
Thanks. This does sound related to my patch. The flakiness seems to be gc-dependent. If you call gc() as the first statement in done(), you can repro 100% of the time. Created attachment 158509 [details]
Need to check JSC
Created attachment 158515 [details]
Patch
Comment on attachment 158515 [details]
Patch
Looks reasonable.
Comment on attachment 158515 [details] Patch Clearing flags on attachment: 158515 Committed r125656: <http://trac.webkit.org/changeset/125656> All reviewed patches have been landed. Closing bug. |