Bug 94030

Summary: [WebGL] Mac/ATI/AMD systems need to translate built-in GLSL functions
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: gman, kbr, noam, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Dean Jackson 2012-08-14 16:02:33 PDT 
WebGL conformance test suite build: 5a7a067ead6 Tue Aug 7 14:34:42 2012 -0700
WebKit: r125123 on Mountain Lion 12A269
GPU: AMD Radeon HD 6750M 1024 MB (yes, fairly old)
Comment 1 Radar WebKit Bug Importer 2012-08-14 16:04:45 PDT 
<rdar://problem/12099678>
Comment 2 Dean Jackson 2012-08-21 15:34:41 PDT 
It seems like Apple ports, unlike Chrome, are not picking up ANGLE's function emulation. In particular: TFunctionDistance1_1 which is marked as problematic on ATI and NVidia cards.
Comment 3 Dean Jackson 2012-08-21 17:18:40 PDT 
Here is ANGLE adding a distance emulation: 
http://code.google.com/p/angleproject/source/detail?spec=svn1255&r=754
Comment 4 Dean Jackson 2012-08-21 18:19:38 PDT 
Original title was [WebGL] conformance/glsl/functions/glsl-function-distance.html failing on Apple Mountain Lion
Comment 5 Dean Jackson 2012-08-21 18:24:05 PDT 
Created attachment 159835 [details]
Patch
Comment 6 WebKit Review Bot 2012-08-21 18:26:21 PDT 
Attachment 159835 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:56:  The parameter name "shaderType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Dean Jackson 2012-08-21 18:27:21 PDT 
I deliberately ignored the style warning: didn't want to change an existing parameter def in this patch.
Comment 8 Dean Jackson 2012-08-21 18:28:26 PDT 
*** Bug 94032 has been marked as a duplicate of this bug. ***
Comment 9 Dean Jackson 2012-08-21 18:29:11 PDT 
*** Bug 94031 has been marked as a duplicate of this bug. ***
Comment 10 Tim Horton 2012-08-22 12:29:52 PDT 
Comment on attachment 159835 [details]
Patch

Should probably use a typedef for the flags.
Comment 11 Dean Jackson 2012-08-22 12:59:45 PDT 
(In reply to comment #10)
> (From update of attachment 159835 [details])
> Should probably use a typedef for the flags.

ShCompileOptions is the enum of the various options. Not sure what we could call the typedef - maybe ANGLECompileOptions? Anyway, this code will be updated very soon and I'll address it then.
Comment 12 Dean Jackson 2012-08-22 13:14:21 PDT 
Committed r126342: <http://trac.webkit.org/changeset/126342>