Bug 93997

Summary: [Chromium] Fix warnings on Windows build
Product: WebKit Reporter: Scott Graham <scottmg>
Component: New BugsAssignee: Scott Graham <scottmg>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Scott Graham
Reported 2012-08-14 10:31:22 PDT
[Chromium] Fix warnings on Windows build
Attachments
Patch (5.57 KB, patch)
2012-08-14 10:34 PDT, Scott Graham 		no flags
DetailsFormatted DiffDiff
Patch (5.88 KB, patch)
2012-08-14 16:48 PDT, Scott Graham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Scott Graham
Comment 1 2012-08-14 10:34:58 PDT
Created attachment 158365 [details] Patch
Kentaro Hara
Comment 2 2012-08-14 16:30:11 PDT
Comment on attachment 158365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158365&action=review > Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56 > EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5))); Don't you also need to change 0.5 to 0.5f?
Scott Graham
Comment 3 2012-08-14 16:35:27 PDT
(In reply to comment #2) > (From update of attachment 158365 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158365&action=review > > > Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56 > > EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5))); > > Don't you also need to change 0.5 to 0.5f? No, 0.5 is exactly representable as a float, so there's no truncation.
Kentaro Hara
Comment 4 2012-08-14 16:43:14 PDT
Comment on attachment 158365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158365&action=review >>> Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56 >>> EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5))); >> >> Don't you also need to change 0.5 to 0.5f? > > No, 0.5 is exactly representable as a float, so there's no truncation. Makes sense. Then let's add the comment. People will wonder why this test uses 0.3f and 0.5.
Scott Graham
Comment 5 2012-08-14 16:48:32 PDT
Created attachment 158445 [details] Patch
Kentaro Hara
Comment 6 2012-08-14 16:52:35 PDT
Comment on attachment 158445 [details] Patch Looks OK
WebKit Review Bot
Comment 7 2012-08-14 17:33:36 PDT
Comment on attachment 158445 [details] Patch Clearing flags on attachment: 158445 Committed r125625: <http://trac.webkit.org/changeset/125625>
WebKit Review Bot
Comment 8 2012-08-14 17:33:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.